Change to 'pointer' for norman fields #25
Merged
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norman removed the 'nullablestring' type in favor of a 'pointer' attribute for field types[1]. In addition to string pointers, this can be used on maps and slices to indicate the generated client code should become a pointer, even if the original type was not. [1] rancher/norman#400
thedadams
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
norman removed the 'nullablestring' type in favor of a 'pointer'
attribute for field types[1]. In addition to string pointers, this can
be used on maps and slices to indicate the generated client code should
become a pointer, even if the original type was not.
[1] rancher/norman#400
rancher/rancher#32440
rancher/rancher#32553