Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the only system nodepool from cluster via API does not show error #619

Closed
1 task done
valaparthvi opened this issue Aug 5, 2024 · 1 comment
Closed
1 task done

Removing the only system nodepool from cluster via API does not show error #619

valaparthvi opened this issue Aug 5, 2024 · 1 comment
Assignees
@mjura @cpinjani
Labels
kind/bug Something isn't working
Milestone
v2.10.0

Comments

@valaparthvi
Copy link
Contributor

valaparthvi commented Aug 5, 2024 •
edited by mjura
Loading

Rancher: v2.9-0d8af1460cfc73c3bf4bafecc38f399ea5c187a3-head
Dashboard: release-2.9 65f0232
Operator Version: rancher-aks-operator:104.0.1+up1.9.0

Steps to reproduce:

  1. Import a cluster with a single 'System' mode nodepool, and a user mode nodepool
  2. Removing the 'System' mode nodepool via API

Result:
The update does not result in cluster to error out.
The UI shows error 'At least 1 system nodepool is required, but there is no error in the operator logs or cluster object.

For a provisioned cluster, the operator logs and cluster.Transitioning and cluster.TransitioningMessage both show appropriate error messages.

image

image

PR's:
@mjura mjura self-assigned this Oct 7, 2024
@mjura mjura moved this from Backlog to In Progress (8 max) in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Oct 7, 2024
@mjura mjura added this to the v2.10.0 milestone Oct 17, 2024
mjura added a commit to mjura/aks-operator that referenced this issue Oct 21, 2024
@mjura
Prevent from removing last node pool with mode System
25d3a79 
Issue: rancher#619
@mjura mjura mentioned this issue Oct 21, 2024
Merged
5 tasks
mjura added a commit to mjura/aks-operator that referenced this issue Oct 21, 2024
@mjura
Prevent from removing last node pool with mode System
4dcb7bb 
Issue: rancher#619
@mjura mjura moved this from PR to be reviewed to In Progress (8 max) in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Oct 25, 2024
@mjura mjura moved this from In Progress (8 max) to To Test in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Oct 25, 2024
@cpinjani cpinjani self-assigned this Oct 29, 2024
@cpinjani
Copy link
Contributor

Validation passed on build: v2.10-head, aks-operator:v1.10.0-rc.2
Removing the only system nodepool from provisioned/imported cluster via API throws error

image

@kkaempf kkaempf added the kind/bug Something isn't working label Nov 5, 2024
@cpinjani cpinjani mentioned this issue Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjura mjura

@cpinjani cpinjani

Labels
kind/bug Something isn't working
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Archived in project
Milestone
v2.10.0
Development

No branches or pull requests
4 participants
@kkaempf @mjura @valaparthvi @cpinjani