Map mac port forwards to 0.0.0.0 #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the use of priviledged ports and makes content available on the machines IP. Part of rancher-sandbox#566 Signed-off-by: Matt Farina <[email protected]>
|
Note, you need the latest lima (tip of master) running in RD to test with privileged ports |
jandubois
approved these changes
Sep 18, 2021
|
This looks kinda insecure unless explicitly documented |
|
My suggestion is: lima-vm/lima#45 (comment) Write a custom forwarder that binds on 0.0.0.0 but rejects connections when srcIP != 127.0.0.1 EDIT: lima PR lima-vm/lima#283 |
I believe that is intentional, as it matches the behaviour of Docker Desktop for Mac (I have not verified). I would hope that eventually this would be configurable via the UI. E.g. if I'm only using k3s, then I may only want to have the traefik ingress ports forwarded to the external interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the use of priviledged ports and makes content
available on the machines IP.
Part of #566