Add i18n localized strings to images component #586
Conversation
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
| @@ -25,44 +25,44 @@ | |||
| <Card :show-highlight-border="false" :show-actions="false"> | |||
| <template #title> | |||
| <div class="type-title"> | |||
| <h3>Image Acquisition</h3> | |||
| <h3>{{ t('images.manager.title') }}</h3> | |||
There was a problem hiding this comment.
I believe we can use v-text here. I'm actually not sure if that's clearer, though. This applies to similar constructs as well.
There was a problem hiding this comment.
It really comes down to style preference. I think we prefer the mustache syntax in dashboard, but I'm willing to stick with whatever we prefer for Rancher Desktop.
There was a problem hiding this comment.
Oh I have no idea what we prefer; just went through Vue docs at one point… :D
We might want to look at strategies for keeping the two separate. I've created #589 so we can track this progress |
This addresses a small piece of tech debt by adding i18n localized strings to the images component.
#585