-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tray icons for macOS #577
Add new tray icons for macOS #577
Conversation
I think the problem is that "stopping" is taking a very short amount of time, and then the app exits, so there is no way to show the "stopped" state. I was going to create an issue about our mental app model (do we have one or two apps (gui and background/helper/...), and what is the relationship between them from the user's point of view (like what does it mean to stop one vs. the other). But I haven't been able to clarify my own thinking about it enough to actually write it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the DCO trailer. The run logs has instructions.
src/main/tray.ts
Outdated
return os.platform() === 'darwin'; | ||
} | ||
|
||
private trayIconsMacOs = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this should be readonly
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - updated to include the readonly
modifier
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
a258115
to
0b55c8b
Compare
Signed-off-by: Phillip Rak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the stopping and stopped ones. I don't know if we'll have a case where we can show stopped. We can investigate that in the future.
These look better than what we have today.
This adds new template icons for use in the tray for macOS.
I received an icon set that represents different states (one for starting, started, stopping, stopped, and error), and I noticed that we don't necessarily have corresponding icons in windows. We don't really make use of stopped and stopping anywhere in the project, but I was thinking that it might be a good idea to get the remaining icons now for ease of use.
Alternatively, we can remove stopped and stopping from the macOS collection.
#236