Add interface for UUID-related exceptions #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the exception thrown during the creating of an instance of a UUID requires intimate knowledge of the codec/builder relationship, I had a delve, and thought the simplest answer would be to give them an interface. This allows catching a
UuidExceptionInterface $e
which will keep the necessary knowledge lighter in the enclosing class.Motivation and context
How has this been tested?
I ran the existing test suite, after seeing you are catching on specific exceptions. Because the use of the interface to catch is optional, it didn't look like I needed to refactor there, as the tests are after the more specific detail of the exception anyway.
Types of changes
Checklist:
composer run-script test
locally, and there were no failures or errors. (Well there was one but not related, phan complained aboutMethod Ramsey\Uuid\Converter\Number\GenericNumberConverter::fromHex() should return string&numeric but returns string.
So it's not my fault ;-)