fix(value-extractor-trait): Fix #122 #123
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow elements to have values extracted from them if they have a private property and public method with teh same name. See #122
Right now the value extractor fails as soon as it tries to access the private property, and does not extract the value from the public method.
Description
This adds some reflection to first check if the property is public, and if not tries the method. To minimize performance impact it only does this if both a property and method of the same name exist.
How has this been tested?
Added the test cases exposing the bug, then implemented the fix.
Types of changes
PR checklist