Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(value-extractor-trait): Fix #122 #123

Closed
wants to merge 1 commit into from
Closed

fix(value-extractor-trait): Fix #122 #123

wants to merge 1 commit into from

Conversation

fvdb
Copy link

@fvdb fvdb commented Apr 29, 2023

This will allow elements to have values extracted from them if they have a private property and public method with teh same name. See #122

Right now the value extractor fails as soon as it tries to access the private property, and does not extract the value from the public method.

Description

This adds some reflection to first check if the property is public, and if not tries the method. To minimize performance impact it only does this if both a property and method of the same name exist.

How has this been tested?

Added the test cases exposing the bug, then implemented the fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@fvdb fvdb requested a review from ramsey as a code owner April 29, 2023 02:24
@fvdb fvdb closed this by deleting the head repository Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant