-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth tests cleanup, they don't modify the user's profile anymore #226
Conversation
@thecakeisalie25, remembering your comment in #154, I've just cleaned up the tests with oauth in this PR and I wouldn't really add them to an automatic flow. It's impossible to fully revert all of the changes the tests may apply (the queue can't be restored, for example), and it's still quite annoying if you're playing music at the same time (some songs play for a fraction of a second, etc). I wouldn't like these things happening whenever a new commit reaches Check out these tests and see for yourself. |
As a warning: I'm leaving on a couple weeks of vacation, I'll be back for more stuff! |
I'm back! Is there anything else left in order to merge this? |
The CI failed :) |
I have no clue why the tests failed, honestly. I've added the |
Description
This PR takes care of the "Authenticated tests should actually not modify the user's account and cause minimal changes (as in, don't completely delete the user's library for a test)." task in #127.
It also includes some fixes so that they work:
ARTIST
, expected one ofartist
,track
,genre
#225playlist_unfollow
,playlist_change_detail
take a&str
for the Id, but it should be anId
type #227playlist_reorder_tracks
doesn't need theuris
parameter #228playlist_unfollow
should returnClientResult<()>
#229resume_playback
#231Dependencies
None
Type of change
Please delete options that are not relevant.
How Has This Been Tested?