Implement more details section to highlight R4MP #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczz
force-pushed
the
R4MPHighlights
branch
2 times, most recently
from
346a654 to
50d7bd1
Compare
|
I commented out the selectable section code. We'll add this once we have metrics. Demo link for moving the section to the top: https://ramp4-pcar4.github.io/ramp-website/R4MPHighlights/ |
spencerwahl
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @szczz)
yileifeng
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of the clickable sections that reveal more information about R4MP improvements.
I haven't added anything for Enhanced Interface or Developer Friendly yet, but there is a placeholder for faster than ever.
Will need to get metrics and feedback from the entire team. #51
This change is