Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional feature to accept RFC 3339 timestamps, for compatibility with Auth0 #55

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Conversation

andrewhickman
Copy link
Contributor

Fixes #23

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #55 (ffaf7d3) into main (f4a9902) will decrease coverage by 0.03%.
The diff coverage is 69.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   76.81%   76.78%   -0.04%     
==========================================
  Files          16       16              
  Lines        3472     3480       +8     
==========================================
+ Hits         2667     2672       +5     
- Misses        805      808       +3     
Impacted Files Coverage Δ
src/claims.rs 13.58% <ø> (ø)
src/types.rs 73.00% <60.00%> (-0.83%) ⬇️
src/id_token.rs 93.87% <100.00%> (+0.03%) ⬆️
src/macros.rs 73.13% <100.00%> (+1.07%) ⬆️
src/verification.rs 84.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a9902...ffaf7d3. Read the comment docs.

@ramosbugs ramosbugs merged commit 74037c4 into ramosbugs:main Dec 23, 2021
@ramosbugs
Copy link
Owner

Thank you!

@ThomasLamprecht
Copy link

Is there any reason that this is an (optional) feature? It doesn't pull in any new dependency FWICT and runtime overhead of that additional match shouldn't be too bad, and users of this crate would benefit from working with more providers by default.

I mean, I'll enable it and be done for my use case, so no biggie for me personally, but after reading the release notes and upgrading did not solve auth0 access I had to read more closely and check the PR itself, I wondered for the reason behind that feature guard.

@ramosbugs
Copy link
Owner

it's optional because Auth0 does not follow the OpenID Connect standard, and this library adheres to the standard in its default configuration

ProxBot pushed a commit to proxmox/proxmox-openid-rs that referenced this pull request May 11, 2022
It doesn't pull in any new dependency and we require it to be able to
work with the auth0 provider.
ramosbugs/openidconnect-rs#55 (comment)

Signed-off-by: Thomas Lamprecht <[email protected]>
philipcristiano added a commit to philipcristiano/rust_service_conventions that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse updated_at timestamp from Auth0
3 participants