pass along "style" param from htmlwidgets html to custom html #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the "style" param is necessary in order to have non-default width/height eg. `fooWidget(width = "50%")` without passing along the style, the width won't actually be 50%. And I'm wondering if we need to use the `...` arguments at all? Or is it always safe to ignore them?
|
Maybe a bad example, span tags don't respect width anyway... (unless you change their display mode to e.g. inline-block) |
|
@jcheng5 true, I neglected to realize this is a span specifically. Maybe the example should be left as-is but there should be a note nearby that says that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the "style" param is necessary in order to have non-default width/height eg.
fooWidget(width = "50%")without passing along the style, the width won't actually be 50%.And I'm wondering if we need to use the
...arguments at all? Or is it always safe to ignore them?