This repository has been archived by the owner on Apr 22, 2022. It is now read-only.
Add rpm to Linux build outputs. #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly defining `depends` for the defaults is not necessary as of electron-userland/electron-builder#502
|
Thank you so much! I will take a look and add this for next version. 😃 |
TheGoddessInari
referenced
this pull request
in TheGoddessInari/hamsket
Jul 16, 2018
Add rpm to Linux build outputs.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @saenzramiro! Thanks so much for creating Rambox – so far I was using the gzipped version, but I would love to just install & update it via RPM. I only had to add one output type and remove the
dependsoption, as electron builder will use defaults (see electron-userland/electron-builder#502) if you don't specify them (and the package names are probably different anyways for RPM based distributions).All in all it seems to work pretty well (on Fedora 24, that is):
