Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method - (void)closeCurrentModule in UIViewController (RamblerViperModuleTransitionHandlerProtocol) is not working properly #1

Closed
etolstoy opened this issue Nov 10, 2015 · 1 comment
Labels

Comments

@etolstoy
Copy link
Collaborator

The implementation of this method gets stuck in the following case - we have a modal UINavigationController with a stack of UIViewControllers. Currently it will close the modal controller, no matter where you called this method. The problem is in this sequence:

- (void)closeCurrentModule {
    if (self.presentingViewController) {
        [self dismissViewControllerAnimated:YES completion:nil];
    }
    else if ([self.parentViewController isKindOfClass:[UINavigationController class]]) {
...
@AndreyZarembo
Copy link
Contributor

Fixed in 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants