Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mvn dependency or jar file of resol-vbus-java instead of source code #6

Closed
ramack opened this issue Jan 7, 2018 · 1 comment
Closed

use mvn dependency or jar file of resol-vbus-java instead of source code #6

ramack opened this issue Jan 7, 2018 · 1 comment
Labels
implementation detail

Comments

@ramack
Copy link
Owner

ramack commented Jan 7, 2018

I asked on
https://community.openhab.org/t/best-practice-for-external-libraries/38218

for best practices on external libs inclusion. Definitly using the source directly is not a good idea, we should adjust it to include a jar, possibly to download it during build via maven?
@ramack ramack mentioned this issue Dec 11, 2018
Merged
ramack referenced this issue in codeworkx/openhab2-addons Sep 25, 2019
@codeworkx
re-import resol binding and rework for 2.5.0 compat
3b989e5 
resol: switch to vbus-0.3.0

resol: fix compilation errors
@codeworkx
Copy link

codeworkx/ramack-openhab2-addons@f2aaeb0

ramack pushed a commit that referenced this issue Jun 4, 2020
@vkoop
[yeelight] Add support for yeelight 650 with ambient light (Closes #6… (
98e3746 
openhab#6749)

* [yeelight] Add support for yeelight 650 with ambient light (Closes openhab#6227)

Signed-off-by: Viktor Koop <[email protected]>
@ramack ramack closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implementation detail
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramack @codeworkx