Support for qemu-img for disk detection #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do no additional magic when a file is a zip file, but check if we can access the avfs mountpoint as a directory. * Rename avfs.raw to avfs * Use a custom afvs mountpoint instead of the default homedir mountpoint. The homedir mountpoint could cause trouble with directory permissions (and avfs mountpoint could also be set to a different directory with env variables)
…UID. I haven't verified the working of disktype at this time.
…, which is much easier to type
…, which is used as fallback if avfs does not contain an image. Can be disabled.
…pecified), perhaps the OS can salvage it (probably not)
…g suffices, and other tiny cleanups
…passing self to util functions
…int a bit more reilable)
Increase the allowed file extension length for segmented images. Resolves ralphje#22
Auto mount support for vbox images
Change parameters of xmount around and update --rw to --cache
- Create classes for CommandDependency, PyModuleDependency. - Add special class for handling "magic" dependency. - Add DependencySection class for grouping dependencies. - Simplify CheckAction to use these new classes Output of `imount-check` should be identical to before.
ralphjeGH-28: Refactor dependencies to allow programmatic access.
…e process, simplified disk detection method
|
Thanks for the PR. I want to change the way this works by using a similar class-based system as I did with volume types. The Disk class is desperate need of a rewrite, so I'll leave this PR open for now until I figured that one out. |
|
This PR was closed automatically because I added LFS to the repository for the disk images. I will try to cherry-pick the relevant commits in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
qemu-img infoduring detection of disk image format.In the process, simplified disk detection method and added support for parallels images.
Other formats can now easily be added in disk.py