Fix README.md and build issues #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
force-pushed
the
fix-badges
branch
2 times, most recently
from
108bbc2 to
4f184c2
Compare
jeffmay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 5 5
Lines 90 90
Branches 10 10
=======================================
Hits 82 82
Misses 8 8Continue to review full report at Codecov.
|
- Upgrade to sbt 1.0 to solve a weird bug with MiMa (lightbend-labs/mima#206) - Add missing resolver - Remove name supression config - Fix resolver issue
sklei2
approved these changes
Sep 28, 2018
mingy711
approved these changes
Sep 28, 2018
- +test will download both versions of scala, so we were testing both versions twice and slowing down the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rallyhealth/engineers @mingy711 @sklei2
So I started by trying to fix the badges in the README.md, but CI pointed out that my build issue from before is still an issue.
In the process of fixing these issues, I went down a rabbit hole chasing this bug lightbend-labs/mima#206