downgrade clippy to stable until clap-rs/clap#4733 is fixed

ralexstokes · Feb 28, 2023 · 66c47be · 66c47be
1 parent ce3cba3
commit 66c47be
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -51,7 +51,7 @@ jobs:
       - name: Install toolchain
         uses: dtolnay/rust-toolchain@nightly
         with:
-          components: rustfmt, clippy
+          components: rustfmt
 
       - name: Rust cache
         uses: Swatinem/rust-cache@v2
@@ -61,5 +61,10 @@ jobs:
       - name: Check format
         run: cargo +nightly fmt --all --check
 
+      # TODO remove after `clap` is fixed
+      - name: Install stable clippy
+        run: rustup component add clippy # --toolchain 1.67-x86_64-unknown-linux-gnu
+
       - name: Check clippy
-        run: cargo +nightly clippy --all-targets --all-features --all --verbose -- -D warnings
+        # TODO restore +nightly after fixing this: https://github.com/clap-rs/clap/issues/4733
+        run: cargo clippy --all-targets --all-features --all --verbose -- -D warnings
diff --git a/justfile b/justfile
@@ -15,7 +15,8 @@ test:
 fmt:
     cargo +nightly fmt --all
 lint: fmt validate-example-config
-    cargo +nightly clippy --all-targets --all-features --all
+    # TODO restore +nightly after fixing this: https://github.com/clap-rs/clap/issues/4733
+    cargo clippy --all-targets --all-features --all
 build:
     cargo build --all-targets --all-features --all
 run-ci: lint build test run-integration-tests