Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize phase0 attestation processing #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EchoAlice
Copy link
Contributor

@EchoAlice EchoAlice commented Dec 2, 2024

Optimize Phase0 Attestation Processing

Summary

Optimizes epoch_processing::get_inclusion_delay_deltas() by restructuring attestation processing flow, reducing epoch boundary block processing time by 88.8%.

Problem

The original implementation iterates through all pending attestations for each validator, creating a significant performance bottleneck in state_transition().

Solution

Restructures attestation processing to perform a single pass through pending attestations:

// Before
for validator in unslashed_validators {
    for attestation in pending_attestations {
        // Process each attestation for every validator
    }
}

// After
for attestation in pending_attestations {
    let validator_indices = calculate_validator_indices(attestation);
    // Process attestations once, mapping delays to validator indices
}

Performance Impact

Tested at slot 3,200 (20,488 validators, 225 pending attestations):

Processing time: 1.81hrs → 12.2 minutes
8.93x faster

Testing

Verified correctness against reference implementation
Benchmarked with mainnet data at slot 3,200

Next steps:

  • Similar optimizations planned for Altair, Bellatrix, Capella, and Deneb forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant