Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Fix a bug in query join #40

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

hrkrshnn
Copy link
Contributor

@hrkrshnn hrkrshnn commented Sep 9, 2022

Closes #39

Only tested get_validators for a few pubkeys and filters. Open to ideas on testing this. Tested against a Lighthouse client.

@ralexstokes
Copy link
Owner

don't really have any automated testing for this repo right now

could use an existing implementation and then make some test vectors (url, request, response) and then make sure this library responds appropriately

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thank you :)

@ralexstokes ralexstokes merged commit 5d6d331 into ralexstokes:main Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: extra space in the call leading to BAD_REQUEST: unable to parse query
2 participants