Create Actions job for uploading container image to Harbor #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## k8s-deployment #368 +/- ##
===============================================
Coverage 94.47% 94.47%
===============================================
Files 39 39
Lines 3114 3114
Branches 311 311
===============================================
Hits 2942 2942
Misses 144 144
Partials 28 28 Continue to review full report at Codecov.
|
|
The |
VKTB
changed the title
This was referenced Jun 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #355
Description
The
dockerjob introduced in this PR triggers only if all the other jobs in the CI workflow succeed and the things that it does depend on the context. It has been configured to always build the Docker image (not only on pushes to thek8s-deployment) but only push the image to Harbor if something is pushed to thek8s-deploymentbranch. The former allows to verify whether the Docker image is successfully building during PRs whereas the latter ensures that the image is not pushed during PRs as the proposed changes may be rejected in the end.I have added TODOs to remind us to change the references of
k8s-deploymentbranch tomainin the CI workflow file once thek8s-deploymentbranch has been merged intomain.Testing Instructions
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?