Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom output formatter #97

Merged
merged 7 commits into from
Mar 12, 2018
Merged

Conversation

kpacha
Copy link
Contributor

@kpacha kpacha commented Feb 25, 2018

as requested at #92, this PR changes the rendering strategy so clients can inject the output format for each test

@kpacha
Copy link
Contributor Author

kpacha commented Feb 25, 2018

ouch! the build failed because I'm using the new strings.Builder from 1.10.

Should I upgrade the golang version in the travis config or use any other method to build strings compatible with 1.9?

@kpacha
Copy link
Contributor Author

kpacha commented Mar 9, 2018

@rakyll Why is taking so long to answer my question?

Copy link
Owner

@rakyll rakyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not being responsive. I have some comments on this PR but don't have time for the review at this point. I will merge this and address them in another PR. Thanks much for the feature.

@rakyll
Copy link
Owner

rakyll commented Mar 9, 2018

Can you replace the use of strings.Builder and make sure it builds with Go 1.9?

@rakyll rakyll merged commit 61cf992 into rakyll:master Mar 12, 2018
@rakyll
Copy link
Owner

rakyll commented Mar 12, 2018

Thanks!

chunter0 pushed a commit to chunter0/hey that referenced this pull request Apr 8, 2024
The `/redirect-to` endpoint currently acts as an open redirect, which is
bad for any go-httpbin instance exposed to the public internet.

This allows configuring an allowlist of domains to which traffic can be
redirected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants