common: add test for connection with keyFilePath. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| email: 'x@provider', | ||
| privateKey: '/some/path', | ||
| scopes: ['scope1', 'scope2'] | ||
| describe('Token', function() { |
There was a problem hiding this comment.
All I did was move the other tests that were previously in this file to the Token describe block, as they all were testing Token-y functionality. No changes to the code, other than using connection.Connection, instead of conn.Connection.
|
Looks good, I'd prefer to keep the filename as filename. |
|
Ready to go! |
rakyll
pushed a commit
that referenced
this pull request
Aug 8, 2014
common: add test for connection with keyFilePath.
|
Thanks! We can merge the PR opened against the main repo now I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to work on less scary PRs. Sorry! Will annotate.