Use NativeLibs:auth<github:salortiz> instead #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salortiz
reviewed
Jul 16, 2020
There was a problem hiding this comment.
@rbt
As you are removing the built-in file and the mention in META6.json's provides, after releasing this, only one NativeLibs module will exist in the ecosystem,
So, isn't needed qualifying it with :auth<github:salortiz> in use statements nor in META6's depends.
True. I set the auth to get a Travis build using the correct NativeLibs as I'll come back after it's merged and remove :auth. |
This removes the built in NativeLibs:auth<sortiz>:ver<0.0.8> and adds a dependency on the one distributed separately as per discussion in #187. Removal of :auth will be done when (if?) zef stops picking up older DBIish versions for a NativeLibs dependency.
rbt
force-pushed
the
rbt.nativelibs-dependency
branch
from
e3c529e to
65f6d75
Compare
Done. |
JJ
reviewed
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the built in NativeLibs:auth:ver<0.0.8> and adds a dependency on the one distributed separately as per discussion in #187.
This seems to pass without any issues. Oracle isn't tested but Oracle also doesn't use the library.