fix output printing in crashed subprocesses

rainu · Jan 27, 2025 · 1322c49 · 1322c49
1 parent 6711adb
commit 1322c49
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/config/print.go b/config/print.go
@@ -35,3 +35,9 @@ func (p *PrinterConfig) Validate() error {
 
 	return nil
 }
+
+func (p *PrinterConfig) Close() {
+	for _, target := range p.Targets {
+		target.Close()
+	}
+}
diff --git a/controller/base.go b/controller/base.go
@@ -57,14 +57,11 @@ func (c *Controller) beforeClose(ctx context.Context) (prevent bool) {
 
 func (c *Controller) Shutdown() {
 	c.shutdown(c.ctx)
+	c.appConfig.Printer.Close()
 	os.Exit(0)
 }
 
 func (c *Controller) shutdown(ctx context.Context) {
 	c.LLMInterrupt()
 	c.aiModel.Close()
-
-	for _, target := range c.appConfig.Printer.Targets {
-		target.Close()
-	}
 }
diff --git a/main.go b/main.go
@@ -64,6 +64,7 @@ func main() {
 			onStartUp(cfg)
 		}
 	}
+	defer cfg.Printer.Close()
 
 	ctrl, err := controller.BuildFromConfig(cfg, os.Getenv(lastStateEnv))
 	if err != nil {
@@ -95,7 +96,6 @@ func main() {
 			lastStateEnv: ctrl.GetLastState(),
 		}
 
-		//TODO: dont know why stdout doesnt work properly (os.Stderr would work)
 		cmdchain.Builder().WithInput(os.Stdin).
 			Join(os.Args[0], os.Args[1:]...).WithAdditionalEnvironmentMap(ae).
 			Finalize().WithError(os.Stderr).WithOutput(os.Stdout).