Skip to content

Commit

Permalink
feat(autogpt/forge): Send exception details in agent protocol endpoin…
Browse files Browse the repository at this point in the history 
…ts (Significant-Gravitas#7005)

Send exception details in agent protocol endpoints

Co-authored-by: Nicholas Tindle <[email protected]>
  • Loading branch information
@kcze @ntindle
kcze and ntindle authored Mar 12, 2024
1 parent cb1297e commit 89cf015
Show file tree
Hide file tree
Showing 2 changed files with 112 additions and 13 deletions.
86 changes: 73 additions & 13 deletions autogpts/forge/forge/sdk/routes/agent_protocol.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
from forge.sdk.errors import *
from forge.sdk.forge_log import ForgeLogger
from forge.sdk.model import *
from forge.sdk.utils import get_detailed_traceback, get_exception_message

base_router = APIRouter()

Expand Down Expand Up @@ -92,7 +93,13 @@ async def create_agent_task(request: Request, task_request: TaskRequestBody) ->
except Exception:
LOG.exception(f"Error whilst trying to create a task: {task_request}")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)
Expand Down Expand Up @@ -157,7 +164,13 @@ async def list_agent_tasks(
except Exception:
LOG.exception("Error whilst trying to list tasks")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)
Expand Down Expand Up @@ -218,6 +231,7 @@ async def get_agent_task(request: Request, task_id: str) -> Task:
agent = request["agent"]
try:
task = await agent.get_task(task_id)

return Response(
content=task.json(),
status_code=200,
Expand All @@ -233,14 +247,22 @@ async def get_agent_task(request: Request, task_id: str) -> Task:
except Exception:
LOG.exception(f"Error whilst trying to get task: {task_id}")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)


@base_router.get(
"/agent/tasks/{task_id}/steps", tags=["agent"], response_model=TaskStepsListResponse
"/agent/tasks/{task_id}/steps",
tags=["agent"],
response_model=TaskStepsListResponse,
)
async def list_agent_task_steps(
request: Request,
Expand Down Expand Up @@ -300,7 +322,13 @@ async def list_agent_task_steps(
except Exception:
LOG.exception("Error whilst trying to list steps")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)
Expand Down Expand Up @@ -356,6 +384,7 @@ async def execute_agent_task_step(
step = StepRequestBody(input="y")

step = await agent.execute_step(task_id, step)

return Response(
content=step.json(),
status_code=200,
Expand All @@ -368,10 +397,16 @@ async def execute_agent_task_step(
status_code=404,
media_type="application/json",
)
except Exception as e:
except Exception:
LOG.exception(f"Error whilst trying to execute a task step: {task_id}")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)
Expand Down Expand Up @@ -406,6 +441,7 @@ async def get_agent_task_step(request: Request, task_id: str, step_id: str) -> S
agent = request["agent"]
try:
step = await agent.get_step(task_id, step_id)

return Response(content=step.json(), status_code=200)
except NotFoundError:
LOG.exception(f"Error whilst trying to get step: {step_id}")
Expand All @@ -417,7 +453,13 @@ async def get_agent_task_step(request: Request, task_id: str, step_id: str) -> S
except Exception:
LOG.exception(f"Error whilst trying to get step: {step_id}")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)
Expand Down Expand Up @@ -481,7 +523,13 @@ async def list_agent_task_artifacts(
except Exception:
LOG.exception("Error whilst trying to list artifacts")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)
Expand Down Expand Up @@ -538,14 +586,22 @@ async def upload_agent_task_artifacts(
except Exception:
LOG.exception(f"Error whilst trying to upload artifact: {task_id}")
return Response(
content=json.dumps({"error": "Internal server error"}),
content=json.dumps(
{
"error": "Internal server error",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
media_type="application/json",
)


@base_router.get(
"/agent/tasks/{task_id}/artifacts/{artifact_id}", tags=["agent"], response_model=str
"/agent/tasks/{task_id}/artifacts/{artifact_id}",
tags=["agent"],
response_model=str,
)
async def download_agent_task_artifact(
request: Request, task_id: str, artifact_id: str
Expand Down Expand Up @@ -576,7 +632,8 @@ async def download_agent_task_artifact(
return Response(
content=json.dumps(
{
"error": f"Artifact not found - task_id: {task_id}, artifact_id: {artifact_id}"
"error": f"Artifact not found "
"- task_id: {task_id}, artifact_id: {artifact_id}"
}
),
status_code=404,
Expand All @@ -587,7 +644,10 @@ async def download_agent_task_artifact(
return Response(
content=json.dumps(
{
"error": f"Internal server error - task_id: {task_id}, artifact_id: {artifact_id}"
"error": f"Internal server error "
"- task_id: {task_id}, artifact_id: {artifact_id}",
"exception": get_exception_message(),
"traceback": get_detailed_traceback(),
}
),
status_code=500,
Expand Down
39 changes: 39 additions & 0 deletions autogpts/forge/forge/sdk/utils.py
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import inspect
import sys
import traceback


def get_exception_message():
"""Get current exception type and message."""
exc_type, exc_value, _ = sys.exc_info()
exception_message = f"{exc_type.__name__}: {exc_value}"
return exception_message


def get_detailed_traceback():
"""Get current exception traceback with local variables."""
_, _, exc_tb = sys.exc_info()
detailed_traceback = "Traceback (most recent call last):\n"
formatted_tb = traceback.format_tb(exc_tb)
detailed_traceback += "".join(formatted_tb)

# Optionally add local variables to the traceback information
detailed_traceback += "\nLocal variables by frame, innermost last:\n"
while exc_tb:
frame = exc_tb.tb_frame
lineno = exc_tb.tb_lineno
function_name = frame.f_code.co_name

# Format frame information
detailed_traceback += (
f" Frame {function_name} in {frame.f_code.co_filename} at line {lineno}\n"
)

# Get local variables for the frame
local_vars = inspect.getargvalues(frame).locals
for var_name, value in local_vars.items():
detailed_traceback += f" {var_name} = {value}\n"

exc_tb = exc_tb.tb_next

return detailed_traceback

0 comments on commit 89cf015

Please sign in to comment.