Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make wasm traits macro to work with generic types and impl into wasm vec trait #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

make wasm traits macro to work with generic types and impl into wasm vec trait #12

wants to merge 3 commits into from
+661 −30

Conversation

rouzwelt
Copy link
Collaborator

@rouzwelt rouzwelt commented Feb 24, 2025 •
edited
Loading

Motivation

resolves #15
also add better tests

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@rouzwelt rouzwelt requested a review from hardyjosh February 24, 2025 14:33
@rouzwelt rouzwelt self-assigned this Feb 24, 2025
@rouzwelt rouzwelt mentioned this pull request Feb 25, 2025
Closed
4 tasks
@rouzwelt rouzwelt changed the title make wasm traits macro to work with generic types make wasm traits macro to work with generic types and impl into_wasm_vec trait Feb 25, 2025
@rouzwelt rouzwelt changed the title make wasm traits macro to work with generic types and impl into_wasm_vec trait make wasm traits macro to work with generic types and impl into wasm vec trait Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh Awaiting requested review from hardyjosh

Assignees

@rouzwelt rouzwelt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl into vec wasm trait and expand the macro to work with generics
1 participant
@rouzwelt