Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lang/pl/lang.php #619

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Update lang/pl/lang.php #619

merged 3 commits into from
Oct 31, 2020

Conversation

300-30-3
Copy link
Contributor

Fixed typos, and uptaded pl language to latest version

Fixed typos, and uptaded pl language to latest version
@mjauvin
Copy link
Contributor

mjauvin commented Oct 30, 2020

Please leave the opening php tag on its own line and keep the spacing before the return.

@LukeTowers
Copy link
Contributor

@mjauvin I will note that I personally prefer that the return statement is on the same line as the opening PHP tag for language files, but we haven't enforced one way or the other throughout our codebase yet.

@LukeTowers
Copy link
Contributor

@mjauvin if you're up for it these tests need to be fixed by forcing Composer to 1.0 for now like Ben did in the main repo, or you could test the Composer 2.0 fix PR in the wikimedia-merge-plugin with October so that we can move onto the next version of that plugin and the tests will fix themselves.

@mjauvin mjauvin added this to the 1.7.4 milestone Oct 31, 2020
Update GitHub Actions to use Composer v1 for the moment
@mjauvin mjauvin merged commit 535883c into rainlab:master Oct 31, 2020
@mjauvin
Copy link
Contributor

mjauvin commented Oct 31, 2020

Thanks for your contribution @mikolajklek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants