Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to export default locale #577

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

Samuell1
Copy link
Member

@Samuell1 Samuell1 commented Apr 28, 2020

Fixes #422

Reworked original PR from few years ago #431

@Samuell1 Samuell1 changed the title Allow to export, import default locale Allows to export default locale Apr 28, 2020
@mjauvin
Copy link
Contributor

mjauvin commented Apr 28, 2020

Samuell, it would need to be triggered by an additional checkbox to be accepted, otherwise it will break the current behavior. (e.g. include original key)

@Samuell1
Copy link
Member Author

Samuell1 commented Apr 28, 2020

@mjauvin yes you can disable it or enable in export menu. And this isnt breaking change everything works same.

@mjauvin
Copy link
Contributor

mjauvin commented Apr 28, 2020

@Samuell1 could you set this new column to UNCHECKED by default to keep existing behavior?

@Samuell1
Copy link
Member Author

@mjauvin Not sure if ocms supports that for export.

@mjauvin mjauvin added this to the 1.7.2 milestone May 5, 2020
@mjauvin mjauvin merged commit b1ea008 into rainlab:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants