Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe mode prevents translation of placeholder content #434

Closed
hallosascha opened this issue Mar 6, 2020 · 2 comments
Closed

Safe mode prevents translation of placeholder content #434

hallosascha opened this issue Mar 6, 2020 · 2 comments
Assignees
@bennothommo
Labels
Status: Completed Type: Bug

Comments

@hallosascha
Copy link

  • OctoberCMS Build: 464
  • RainLab Pages Plugin Version: 1.3.2
  • RainLab Translate Plugin Version: 1.6.7
  • PHP Version: 7.2

Related to:

issue #174

Description:

When in safe mode, I cannot edit the translations of placeholder content (using the RainLab Translate Plugin). I can edit the content and its translations. I can edit the placeholder content of the default language. But editing placeholder content of another language gives me the warning "Safe mode is currently enabled. Editing the PHP code of CMS templates is disabled."

Steps To Reproduce:

  • Use StaticPages and Translate Plugin.
  • Define a language that is not default.
  • Create a static page with a layout which defines a placeholder.
  • Edit the placeholder content for the non-default language.

Thanks for looking at the issue! (should this issue also be opened for the Translate Plugin?)
@bennothommo
Copy link
Contributor

@hallosascha This should be fixed with this commit to the Translate plugin: rainlab/translate-plugin@610aa79

@hallosascha
Copy link
Author

Wow, that was quick! Thanks a lot!

mjauvin added a commit to rainlab/translate-plugin that referenced this issue Mar 20, 2020
@mjauvin @GinoPane
@aurelien-roy @Trysystems
escape Message translate params value to prevent XSS attack (#554)
4a3d601 
* runs params value through htmlspecialchars() to escape html content

* add note about escaped content in translated messages

* use Html::clean() instead of e()

* Revert "add note about escaped content in translated messages"

* escape params when translating messages; introduce transRaw method for legacy usage

* Fix for #376 (#559)

Fix for #376

* Add support for transOrderBy (#516)

Add support for transOrderBy

* update version file for 1.6.8 release

* Disable safe mode checks for ML Static Pages.

Fixes rainlab/pages-plugin#434. Refs: rainlab/pages-plugin#174, rainlab/pages-plugin@6b6b061

* Clear RainLab.Pages caches when saving a static page

Fixes rainlab/pages-plugin#404

* Register asset bundle (#560)

* make sure multi-lingual input form controls have padding-right of 44px
* register asset bundle to process less files into css files
* reposition language selector above textarea box
* fix language selector position when commentAbove is defined

* Update version file for 1.6.9 release

* Fix error with casts fields default locale value (#556)

* only call setLocale() if locale has changed (#561)

* remove unused module

Co-authored-by: Siarhei Karavai <[email protected]>
Co-authored-by: Aurélien Roy <[email protected]>
Co-authored-by: Ben Thomson <[email protected]>
Co-authored-by: Luke Towers <[email protected]>
Co-authored-by: Trysystems <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennothommo bennothommo

Labels
Status: Completed Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hallosascha @bennothommo