Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for invalid and wildCard ranges with --newest option #610

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

vanodevium
Copy link
Contributor

Fixed successful work in case of incorrect ranges.
For omitting errors like #608

@raineorshine
Copy link
Owner

Thank you!

@raineorshine raineorshine merged commit ec85d80 into raineorshine:master Nov 8, 2019
@vanodevium
Copy link
Contributor Author

@raineorshine Have you thought about improving branch coverage?

@raineorshine
Copy link
Owner

You mean like unit tests for other branches? Sorry I'm not familiar. Can you explain a bit?

@vanodevium
Copy link
Contributor Author

No, in master branch.
If you look at test coverage, you will see that not all conditions are covered in if/else/ternary operator statements. It is called branch coverage.

@raineorshine
Copy link
Owner

Ah! That kind of branch :). Yes, we could really use better coverage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants