Patch react-native vibration module #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
force-pushed
the
@brunobar79/vibrate-react-native-patch
branch
from
a269f5d
to
9061214
Compare
jinchung
added a commit
that referenced
this pull request
Feb 12, 2020
* emoji selector wip * Improve selector transitions * Better selector, add color buttons and avatar * Rename EmojiSheet -> AvatarBuilder * replace colorCircle, add fixed header and color animator * replace flatlist with recyclerlistview in EmojiSelector and add basic functionalities * add categories tab blocker * add profile masthead set props for avatar builder * add saving selected emoji to redux * fix eslint for files and remove old emojiselector * fix default color issue * add saving emoji and color into local storage * make initial loading shorter by rewriting rendering method * fix overscroll emoji list issue * add loading emoji placeholder and wallet screen avatar * fix spaces between white lines * change sticky header style to remove overlay * fix initial value for scrollPosition * Revert "Revert "Merge pull request #252 from rainbow-me/@jin/send-remove-redux"" This reverts commit 7838066. * Consolidate send sheet and send sheet with data * Use hooks for SendSheet * Cleanup of setState functions * rewrite button press animation * Fix gesture state * opacity and longpress * state machine * Decrease animation duration, increase scaleTo values * Fix all issues * fix interpolation * Revert ProfileAction scaleTo change * Utilize useMemoOne for creation of animated Values inside ButtonPressAnimation * slightly opinionated refactoring of Michals latest BPA rewrite * use State enum instead of numbers for BPA state machine * Fix broken BPA onPress functionality * add new styles for swap transactions * add missing transaction types * change arrow icon for received transactions * consolidate SwapIcon assets and add "small" boolean flag * Add color to "received" swap status badges to match design spec * Ignore error from wallet eth zero check while importing * try procs * Reduce default ButtonPressAnimation duration * finish * fix edge issue * add pending request count to determine isEmpty variable * Update stack and use native stack where possible (#308) * bump yarn * Rename BPA procs and fix lint * Remove tests from hooks and add linting and testing to travis instead of e2e (currently broken) * Fix BPA * Show cTokens in balances * Add experimental discover sheet skeleton (#321) * Add discover sheet * redash * Fix bottom sheet * Add experimental config Co-authored-by: Christian Baroni <[email protected]> * Bump screens and stack * Bump reanimated * New experimental ExpandedState's with charts (#247) * Follow up with native changes after bumping * fix framework not found InputMask issue * fix jest-setup * bump react navigation stack * merge value charts into follow up * fix import in modal * add tap recognize for value chart * add handling for modal closure while touching chart * add handling for modal dismiss in chart and fix eslint * change size values to keep path ratio * little design changes to keep loading line in the middle of chart box * add change of line width during touch animation * remove initial loading size change * initial implementation of new layout for value charts * fade in-out min-max values in chart * initial implementation for smooth changing charts * add handling for non existant data in dataset * remodel awaits to make downloade new charts possible * logic for setState new charts fix * add better switching between tap and pan * add simply data function to make 288 point charts and change data * change timestaps logic for simpified charts * add activity indicator for chart loading * remove high interval rule * fix animation * State.FAILED * change logic to remove unnecessary delay * bump cubic-spline to 3.0.3 * add loading state and open modal faster * add margin values in chart * new touchX calculation for shrinken chart * add arrow instead of up text * add sf pro rounded font * change animation to spring and rotate arrows * add default values for initial loading * improve timespan selector moving animation * improve time selector circle * remove unused things * yarn.lock * Add charts to experimental Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Wojciech Stanisz <[email protected]> Co-authored-by: Christian Baroni <[email protected]> * Bump reanimated * Fix fetching of currencies * Replace componentWillReceiveProps with getDerivedStateFromProps in SendContactList.js * Fix focusing on selecting currency * Native transaction list and configurable clickable view (#325) I think, that the current implementation of the list is production-ready. I've made some testing on the emulator and it feels way more robust than the initial JS implementation. Hope it will meet your expectations. Aside from that, in the last few commits, you may find a NativeButton component which is nothing other than a ButtonPressAnimation component re-implemented in Swift (as we discussed with @osdnk). I would love to receive your feedback and adjust details for the list and/or button if needed. There are some tiny things that can be improved (code-wise), but they shouldn't anyhow interfere with the business logic of the app, so the PR is safe to merge. * Remove margin bottom from marginBottom * Fixes for swap and pending transactions (#323) * Clarify variable name for uniswap assets in wallet * Fix for deduping pending transactions using nonce * Remove assets with 0 quantity after merge with existing assets * Replacing parseFloat with bignumber operations for swap * Fix for adding year only for previous years (#326) * Bump RLV and resolve strange render in send asset list (#324) * bump RLV and resolve strange indexing in send asset list * revert update keys in send asset list * minor RLV list cleanup (#327) * Bump react-navigation-tabs * Revert "Bump react-navigation-tabs" This reverts commit bdc8213. * Remove blurring from UnderlineField (#329) * Initial android implementation (#328) * Make dedicated stack from SendSheet (#330) streamable.com/dmmsx * Fix focusing keyboard with non-native stack * Add keyboardShouldPersistTaps to SendContactList * Update ethers version (#335) * added script to restart the packager in a clean state (#338) * make send flow work in simulator (#337) * bump and patch react-native-svg (#339) * Feat: Watch pending transactions (#336) * watch pending transactions * clean up * Error handling for watching transactions Co-authored-by: Jin <[email protected]> * Feat: Optimize gas price (#341) * handle send flow and exchange * support walletconnect txs * reorder imports * clean up * remmove unused import * Create SwapDetailsState modal * Improve FloatingEmojis * Add lock icon to TokenSelectionButton and remove UnlockAssetButton * Add e a s t e r e g g to SwapDetails * Make SwapDetailsState refocus input on previous route when unmounting * Prevent undefined exception in OfflineBadge * Prevent FloatingEmojis from crashing experimental transactions list * Add back in the swap execution rate logic that got deleted somehow * Updates related to react-navigation-stack's migration to vanilla Animated react-navigation-stack recently dropped support for `reanimated` and moved back to using vanila Animated. - refactor FloatingEmojis components to allow receiving vanilla Animated values * Include swap execution details after currency selection # Conflicts: # src/screens/ExchangeModal.js * Use unlock creation time to determine most recent time remaining * Fix for floating emojis on profile masthead # Conflicts: # src/components/floating-emojis/FloatingEmojis.js * Restructure navigators * fix exchange stack navigator * fix floating emojis in swapdetails * add transparent background behind swap details * fix ExchangeModalNavigator's gestures' blocking * patch react-native vibration module (#340) * initial implementation of native dynamic profileMasthead * lint only staged files (#343) * Feat: Add networking debugging (#344) * add networking debugging * comment exceptions * Fix minor keyboard glitch when dismissing SwapDetails * Networking debugging (#345) * turn off debug flags by default * improve timeout detection * Update debug.js * fix block polling (#346) * New value charts colorful (#334) Added new charts sections, and new API that enables you to personalize chart by selecting: mode: "gesture-managed" / "detailed" / "simplified" enableSelect: bool - enable checking the value in touched point of the chart amountOfPathPoints: number - the number of points for switch between charts onValueUpdate: func - a callback that returns the value in touched point on the chart barColor: color - specify a color for the touch select bar stroke: { detailed: number, simplified: number } - enables you to specify width of chart line data: object - provide data for the chart Also, this PR links new SF rounded fonts * add support for dynamic emotes and colors in profile header * Bump stack * fix margin size * fix disappearing sticky header on load modal * Add overflow: visible to expandedPreset * update fastlane to latest version (#347) * Add animation to UIButton for selecting emojis * Enhance scale * Update RoundedCornerView.swift * Fix emojis * fix styling for RLV * Move constant to the top of the file * Remove hacks * Migrate to ProgressiveListView * moar clean up * Add isEmulatorSync warn * Add to experimental and fix minor issues * fix flags is Swift * Update TabBar.js * fix styling for color circle when native button is enabled * Update app icon (#350) * Remove unnecessary calls for Uniswap liquidity info (#354) * Remove unnecessary calls for Uniswap liquidity info * Rename rainbow2 back to rainbow * add sentry logging for keychain errors (#353) * Update fastfile and set release for Sentry (#356) * Fix app crash on open of ReceiveModal (#357) * Fix overlay asset screen in not native stack * upgrade deps + include deps needed for add cash * Fix app crash on open of ReceiveModal * Prevent undefined errors related to our usage of RecyclerListView * Fix native stacks for iOS version 13.3.1 Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Wojciech Stanisz <[email protected]> Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Michael Demarais <[email protected]> Co-authored-by: Alexey Kureev <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]>
jinchung
added a commit
that referenced
this pull request
Feb 19, 2020
* emoji selector wip * Improve selector transitions * Better selector, add color buttons and avatar * Rename EmojiSheet -> AvatarBuilder * replace colorCircle, add fixed header and color animator * replace flatlist with recyclerlistview in EmojiSelector and add basic functionalities * add categories tab blocker * add profile masthead set props for avatar builder * add saving selected emoji to redux * fix eslint for files and remove old emojiselector * fix default color issue * add saving emoji and color into local storage * make initial loading shorter by rewriting rendering method * fix overscroll emoji list issue * add loading emoji placeholder and wallet screen avatar * fix spaces between white lines * change sticky header style to remove overlay * fix initial value for scrollPosition * Bump react-navigation-tabs * Revert "Bump react-navigation-tabs" This reverts commit bdc8213. * Remove blurring from UnderlineField (#329) * Initial android implementation (#328) * Make dedicated stack from SendSheet (#330) streamable.com/dmmsx * Fix focusing keyboard with non-native stack * Add keyboardShouldPersistTaps to SendContactList * Update ethers version (#335) * added script to restart the packager in a clean state (#338) * make send flow work in simulator (#337) * bump and patch react-native-svg (#339) * Feat: Watch pending transactions (#336) * watch pending transactions * clean up * Error handling for watching transactions Co-authored-by: Jin <[email protected]> * Feat: Optimize gas price (#341) * handle send flow and exchange * support walletconnect txs * reorder imports * clean up * remmove unused import * Create SwapDetailsState modal * Improve FloatingEmojis * Add lock icon to TokenSelectionButton and remove UnlockAssetButton * Add e a s t e r e g g to SwapDetails * Make SwapDetailsState refocus input on previous route when unmounting * Prevent undefined exception in OfflineBadge * Prevent FloatingEmojis from crashing experimental transactions list * Add back in the swap execution rate logic that got deleted somehow * Updates related to react-navigation-stack's migration to vanilla Animated react-navigation-stack recently dropped support for `reanimated` and moved back to using vanila Animated. - refactor FloatingEmojis components to allow receiving vanilla Animated values * Include swap execution details after currency selection # Conflicts: # src/screens/ExchangeModal.js * Use unlock creation time to determine most recent time remaining * Fix for floating emojis on profile masthead # Conflicts: # src/components/floating-emojis/FloatingEmojis.js * Restructure navigators * fix exchange stack navigator * fix floating emojis in swapdetails * add transparent background behind swap details * fix ExchangeModalNavigator's gestures' blocking * patch react-native vibration module (#340) * initial implementation of native dynamic profileMasthead * lint only staged files (#343) * Feat: Add networking debugging (#344) * add networking debugging * comment exceptions * Fix minor keyboard glitch when dismissing SwapDetails * Networking debugging (#345) * turn off debug flags by default * improve timeout detection * Update debug.js * fix block polling (#346) * New value charts colorful (#334) Added new charts sections, and new API that enables you to personalize chart by selecting: mode: "gesture-managed" / "detailed" / "simplified" enableSelect: bool - enable checking the value in touched point of the chart amountOfPathPoints: number - the number of points for switch between charts onValueUpdate: func - a callback that returns the value in touched point on the chart barColor: color - specify a color for the touch select bar stroke: { detailed: number, simplified: number } - enables you to specify width of chart line data: object - provide data for the chart Also, this PR links new SF rounded fonts * add support for dynamic emotes and colors in profile header * Bump stack * fix margin size * fix disappearing sticky header on load modal * Add overflow: visible to expandedPreset * update fastlane to latest version (#347) * Fix overlay asset screen in not native stack * Add animation to UIButton for selecting emojis * Enhance scale * Update RoundedCornerView.swift * Fix emojis * fix styling for RLV * Move constant to the top of the file * Remove hacks * Migrate to ProgressiveListView * moar clean up * Add isEmulatorSync warn * Add to experimental and fix minor issues * fix flags is Swift * Update TabBar.js * fix styling for color circle when native button is enabled * Update app icon (#350) * Remove unnecessary calls for Uniswap liquidity info (#354) * Remove unnecessary calls for Uniswap liquidity info * Rename rainbow2 back to rainbow * add sentry logging for keychain errors (#353) * Fix status bar color in native stack in send flow navigated from ExpandedAsses (#349) * Release v1.2.4 (#358) * emoji selector wip * Improve selector transitions * Better selector, add color buttons and avatar * Rename EmojiSheet -> AvatarBuilder * replace colorCircle, add fixed header and color animator * replace flatlist with recyclerlistview in EmojiSelector and add basic functionalities * add categories tab blocker * add profile masthead set props for avatar builder * add saving selected emoji to redux * fix eslint for files and remove old emojiselector * fix default color issue * add saving emoji and color into local storage * make initial loading shorter by rewriting rendering method * fix overscroll emoji list issue * add loading emoji placeholder and wallet screen avatar * fix spaces between white lines * change sticky header style to remove overlay * fix initial value for scrollPosition * Revert "Revert "Merge pull request #252 from rainbow-me/@jin/send-remove-redux"" This reverts commit 7838066. * Consolidate send sheet and send sheet with data * Use hooks for SendSheet * Cleanup of setState functions * rewrite button press animation * Fix gesture state * opacity and longpress * state machine * Decrease animation duration, increase scaleTo values * Fix all issues * fix interpolation * Revert ProfileAction scaleTo change * Utilize useMemoOne for creation of animated Values inside ButtonPressAnimation * slightly opinionated refactoring of Michals latest BPA rewrite * use State enum instead of numbers for BPA state machine * Fix broken BPA onPress functionality * add new styles for swap transactions * add missing transaction types * change arrow icon for received transactions * consolidate SwapIcon assets and add "small" boolean flag * Add color to "received" swap status badges to match design spec * Ignore error from wallet eth zero check while importing * try procs * Reduce default ButtonPressAnimation duration * finish * fix edge issue * add pending request count to determine isEmpty variable * Update stack and use native stack where possible (#308) * bump yarn * Rename BPA procs and fix lint * Remove tests from hooks and add linting and testing to travis instead of e2e (currently broken) * Fix BPA * Show cTokens in balances * Add experimental discover sheet skeleton (#321) * Add discover sheet * redash * Fix bottom sheet * Add experimental config Co-authored-by: Christian Baroni <[email protected]> * Bump screens and stack * Bump reanimated * New experimental ExpandedState's with charts (#247) * Follow up with native changes after bumping * fix framework not found InputMask issue * fix jest-setup * bump react navigation stack * merge value charts into follow up * fix import in modal * add tap recognize for value chart * add handling for modal closure while touching chart * add handling for modal dismiss in chart and fix eslint * change size values to keep path ratio * little design changes to keep loading line in the middle of chart box * add change of line width during touch animation * remove initial loading size change * initial implementation of new layout for value charts * fade in-out min-max values in chart * initial implementation for smooth changing charts * add handling for non existant data in dataset * remodel awaits to make downloade new charts possible * logic for setState new charts fix * add better switching between tap and pan * add simply data function to make 288 point charts and change data * change timestaps logic for simpified charts * add activity indicator for chart loading * remove high interval rule * fix animation * State.FAILED * change logic to remove unnecessary delay * bump cubic-spline to 3.0.3 * add loading state and open modal faster * add margin values in chart * new touchX calculation for shrinken chart * add arrow instead of up text * add sf pro rounded font * change animation to spring and rotate arrows * add default values for initial loading * improve timespan selector moving animation * improve time selector circle * remove unused things * yarn.lock * Add charts to experimental Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Wojciech Stanisz <[email protected]> Co-authored-by: Christian Baroni <[email protected]> * Bump reanimated * Fix fetching of currencies * Replace componentWillReceiveProps with getDerivedStateFromProps in SendContactList.js * Fix focusing on selecting currency * Native transaction list and configurable clickable view (#325) I think, that the current implementation of the list is production-ready. I've made some testing on the emulator and it feels way more robust than the initial JS implementation. Hope it will meet your expectations. Aside from that, in the last few commits, you may find a NativeButton component which is nothing other than a ButtonPressAnimation component re-implemented in Swift (as we discussed with @osdnk). I would love to receive your feedback and adjust details for the list and/or button if needed. There are some tiny things that can be improved (code-wise), but they shouldn't anyhow interfere with the business logic of the app, so the PR is safe to merge. * Remove margin bottom from marginBottom * Fixes for swap and pending transactions (#323) * Clarify variable name for uniswap assets in wallet * Fix for deduping pending transactions using nonce * Remove assets with 0 quantity after merge with existing assets * Replacing parseFloat with bignumber operations for swap * Fix for adding year only for previous years (#326) * Bump RLV and resolve strange render in send asset list (#324) * bump RLV and resolve strange indexing in send asset list * revert update keys in send asset list * minor RLV list cleanup (#327) * Bump react-navigation-tabs * Revert "Bump react-navigation-tabs" This reverts commit bdc8213. * Remove blurring from UnderlineField (#329) * Initial android implementation (#328) * Make dedicated stack from SendSheet (#330) streamable.com/dmmsx * Fix focusing keyboard with non-native stack * Add keyboardShouldPersistTaps to SendContactList * Update ethers version (#335) * added script to restart the packager in a clean state (#338) * make send flow work in simulator (#337) * bump and patch react-native-svg (#339) * Feat: Watch pending transactions (#336) * watch pending transactions * clean up * Error handling for watching transactions Co-authored-by: Jin <[email protected]> * Feat: Optimize gas price (#341) * handle send flow and exchange * support walletconnect txs * reorder imports * clean up * remmove unused import * Create SwapDetailsState modal * Improve FloatingEmojis * Add lock icon to TokenSelectionButton and remove UnlockAssetButton * Add e a s t e r e g g to SwapDetails * Make SwapDetailsState refocus input on previous route when unmounting * Prevent undefined exception in OfflineBadge * Prevent FloatingEmojis from crashing experimental transactions list * Add back in the swap execution rate logic that got deleted somehow * Updates related to react-navigation-stack's migration to vanilla Animated react-navigation-stack recently dropped support for `reanimated` and moved back to using vanila Animated. - refactor FloatingEmojis components to allow receiving vanilla Animated values * Include swap execution details after currency selection # Conflicts: # src/screens/ExchangeModal.js * Use unlock creation time to determine most recent time remaining * Fix for floating emojis on profile masthead # Conflicts: # src/components/floating-emojis/FloatingEmojis.js * Restructure navigators * fix exchange stack navigator * fix floating emojis in swapdetails * add transparent background behind swap details * fix ExchangeModalNavigator's gestures' blocking * patch react-native vibration module (#340) * initial implementation of native dynamic profileMasthead * lint only staged files (#343) * Feat: Add networking debugging (#344) * add networking debugging * comment exceptions * Fix minor keyboard glitch when dismissing SwapDetails * Networking debugging (#345) * turn off debug flags by default * improve timeout detection * Update debug.js * fix block polling (#346) * New value charts colorful (#334) Added new charts sections, and new API that enables you to personalize chart by selecting: mode: "gesture-managed" / "detailed" / "simplified" enableSelect: bool - enable checking the value in touched point of the chart amountOfPathPoints: number - the number of points for switch between charts onValueUpdate: func - a callback that returns the value in touched point on the chart barColor: color - specify a color for the touch select bar stroke: { detailed: number, simplified: number } - enables you to specify width of chart line data: object - provide data for the chart Also, this PR links new SF rounded fonts * add support for dynamic emotes and colors in profile header * Bump stack * fix margin size * fix disappearing sticky header on load modal * Add overflow: visible to expandedPreset * update fastlane to latest version (#347) * Add animation to UIButton for selecting emojis * Enhance scale * Update RoundedCornerView.swift * Fix emojis * fix styling for RLV * Move constant to the top of the file * Remove hacks * Migrate to ProgressiveListView * moar clean up * Add isEmulatorSync warn * Add to experimental and fix minor issues * fix flags is Swift * Update TabBar.js * fix styling for color circle when native button is enabled * Update app icon (#350) * Remove unnecessary calls for Uniswap liquidity info (#354) * Remove unnecessary calls for Uniswap liquidity info * Rename rainbow2 back to rainbow * add sentry logging for keychain errors (#353) * Update fastfile and set release for Sentry (#356) * Fix app crash on open of ReceiveModal (#357) * Fix overlay asset screen in not native stack * upgrade deps + include deps needed for add cash * Fix app crash on open of ReceiveModal * Prevent undefined errors related to our usage of RecyclerListView * Fix native stacks for iOS version 13.3.1 Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Wojciech Stanisz <[email protected]> Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Michael Demarais <[email protected]> Co-authored-by: Alexey Kureev <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> * Catch up develop with Release v1.2.4 fixes (#359) * Update fastfile and set release for Sentry (#356) * Fix app crash on open of ReceiveModal (#357) * Fix overlay asset screen in not native stack * upgrade deps + include deps needed for add cash * Fix app crash on open of ReceiveModal * Prevent undefined errors related to our usage of RecyclerListView * Fix native stacks for iOS version 13.3.1 Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Michael Demarais <[email protected]> Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> * fix debug mode builds (#362) * Fix for including minedAt for watched pending txns (#365) * Bugfix: Native stack navigation related issues (#361) * fix navigation / camera issues * clean up * more clean up * rename param * fix android * fix naming * run actions after interactions (#360) * Release v1.2.4 (5) with navigation fixes (#366) * Remove blinking of Keyboard after navigating to Send Sheet (#367) * Remove navigation.goBack from SettingsModal.js to omit blinking of keyboard * Fix clickable tab bar in emoji selector (#364) * New value charts updates (#355) * Support for Uniswap subgraph and all exchanges (#363) * Fetch missing asset prices from Uniswap subgraph * Support historical pricing info from Uniswap * Use only uniswap pairs info for swap receive * Add query for getting all Uniswap exchanges * Section list support * Add sectionlist to react-native-gesture-handler * Set default data in currency selection list to headerless section * Fix swipe conflicting gestures and cleanup * Scroll to top when clearing input * Added 250ms debounce * Fix header section logic Co-authored-by: Bruno Barbieri <[email protected]> * Add Keyboard.dismiss() in HoldToAuthorizeButton.js (#369) * upgrade react-coin-icon * check before unsubscribing (#371) * Exchange modal fixes (#370) * fix input selection crash * fallback to png icons when available * get uniswap exhanges after interactions * add initial savings in RLV * add savings header and global open savings value * initial implementation of saving list interface * change saving list items renderer * add savings sum value to the header and change deposit button animation * add coin icon and $ in savings header * add missing queries * replace react-native views with designated components * add gradient text to the saving row value * add savings value to the balances header Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Jin <[email protected]> Co-authored-by: Michał Osadnik <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Michael Demarais <[email protected]> Co-authored-by: Alexey Kureev <[email protected]>
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 8, 2020
Summary: This PR fixes a compatibility issue with the Vibration module and TurboModules. The TurboModules spec doesn't allow nullable arguments of type Number, causing the following problem:  ## Changelog [iOS] [Fixed] - Make Vibration library compatible with TurboModules. Pull Request resolved: #27951 Test Plan: Just submitted a PR to my own app to fix the issue [here](rainbow-me/rainbow#340) The problem should be reproducible on RNTester due to this line: https://github.com/facebook/react-native/blob/91f139b94118fe8db29728ea8ad855fc4a13f743/RNTester/js/examples/Vibration/VibrationExample.js#L66 and should be working on this branch. Reviewed By: TheSavior Differential Revision: D19761064 Pulled By: hramos fbshipit-source-id: 84f6b62a2734cc09d450e906b5866d4e9ce61124
alloy
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 8, 2020
Summary: This PR fixes a compatibility issue with the Vibration module and TurboModules. The TurboModules spec doesn't allow nullable arguments of type Number, causing the following problem:  [iOS] [Fixed] - Make Vibration library compatible with TurboModules. Pull Request resolved: #27951 Test Plan: Just submitted a PR to my own app to fix the issue [here](rainbow-me/rainbow#340) The problem should be reproducible on RNTester due to this line: https://github.com/facebook/react-native/blob/91f139b94118fe8db29728ea8ad855fc4a13f743/RNTester/js/examples/Vibration/VibrationExample.js#L66 and should be working on this branch. Reviewed By: TheSavior Differential Revision: D19761064 Pulled By: hramos fbshipit-source-id: 84f6b62a2734cc09d450e906b5866d4e9ce61124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also submitted a PR to react-native here, so we can delete this patch once it's gets merged