Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth_sign #2626

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Fix eth_sign #2626

merged 5 commits into from
Dec 6, 2021

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Dec 4, 2021 •
edited by jinchung
Loading

There was a breaking change on Ethers 5.5.0 (source) affecting eth_sign. This PR fixes it

PoW: http://recordit.co/TXct78bmbi

Included a new e2e covering this so it's safe to merge

For QA in release regression:

  • Please test critical path testing for message signing (various dapps etc)

@brunobar79 brunobar79 added eip1559 needs dev review Includes code review AND testing out the branch labels Dec 4, 2021
jinchung
jinchung approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

estebanmino
estebanmino approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brunobar79 brunobar79 merged commit 15b1813 into develop Dec 6, 2021
@brunobar79 brunobar79 deleted the @bruno/fix-eth-sign branch December 6, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@jinchung jinchung jinchung approved these changes

Assignees
No one assigned
Labels
needs dev review Includes code review AND testing out the branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobar79 @jinchung @estebanmino