-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using prettytable #52
Conversation
See prettytable/prettytable#23 for more info. |
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=========================================
+ Coverage 97.89% 97.9% +0.01%
=========================================
Files 1 1
Lines 332 334 +2
=========================================
+ Hits 325 327 +2
Misses 7 7
Continue to review full report at Codecov.
|
c.f. https://build.opensuse.org/package/show/home:jayvdb:py-new/python-pip-licenses , where I use a little sed to change If there are no objections to this patch, pls advise if I should use |
To make codecov happy, should use nocover or (much harder..) create a test scenario to cover these new code paths? |
PTable and prettytable conflict, both using package name 'prettytable' with one as prettytable.py and the other as prettytable/. pip provides no protection against two packages conflicting like these. PTable hasnt maintained backwards compatability, and hasnt been doing releases for a while. This patch allows either to be present.
I have confirmed that it works fine in a pip environment where the prettytable package is installed as an alternative to PTable. Thank you for great work! |
I released as version 1.18.0 |
Thanks. Submitted to openSUSE main Python package collection https://build.opensuse.org/request/show/758780 |
PTable and prettytable conflict, both using package name 'prettytable'
with one as prettytable.py and the other as prettytable/.
pip provides no protection against two packages conflicting like
these.
PTable hasnt maintained backwards compatability, and hasnt been
doing releases for a while.
This patch allows either to be present.