Explicitly documents how to enable CSS modules #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This technique is shown in the document but I wanted to make it more explicit for CSS modules, as it seems like I was not the only one confused. ;)
gauravtiwari
reviewed
Sep 8, 2017
docs/webpack.md
Outdated
| @@ -78,6 +78,31 @@ babelLoader.options.cacheDirectory = false | |||
| module.exports = environment | |||
| ``` | |||
|
|
|||
| ### Overriding Loader Options in Webpack 3+ (for CSS Modules etc.) | |||
|
|
|||
| In Webpack 3+, if you'd like to specify additional or different options for a loader, editing the actual `config/webpack/{loader}.js` file is *not* the way to go. | |||
There was a problem hiding this comment.
Lets remove reference to this config/webpack/{loader}.js, since it no longer exists. All base loaders are inside npm module now.
|
@gauravtiwari thank you! How's this? |
|
@ezuk great thanks 🍰 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technique is shown in the document but I wanted to make it more explicit for CSS modules, as it seems like I was not the only one confused. ;)