Fix issue with "assets:clean" tasks #2385
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
By using task
bundle exec rake 'assets:clean[3]'
gets error:Errno::ENOENT: No such file or directory @ apply2files
Reason
Generated
manifest.json
file contain this content:This converted by
process_manifest_hash(manifest_hash)
to:This lead to duplication for filenames in this array at
files_in_manifest
(example:app-2f5fcfce1c5201c7ae37.js
). After collecting information in variablefiles_to_be_removed
we get this result:As we can see, we marked for remove twice the same file (because we twice search old assets for
app.js
).Solution
By adding
uniq
we can fix this problem.