Allow NODE_ENV to be overridden in webpacker:compile task #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awcodify
reviewed
Jun 26, 2019
| @@ -26,7 +26,18 @@ end | |||
| namespace :webpacker do | |||
| desc "Compile JavaScript packs using webpack for production with digests" | |||
| task compile: ["webpacker:verify_install", :environment] do | |||
| Webpacker.with_node_env("production") do | |||
| node_env = "production" | |||
There was a problem hiding this comment.
node_env = ENV["NODE_ENV"] || "production"
if node_env != "production"
$stdout.puts "Using NODE_ENV=#{ENV["NODE_ENV"]} from local "\
"environment instead of default NODE_ENV=production"
end
|
Fixed here: 4c79d22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1558
Since users might have a default
NODE_ENV=developmentset in their.envrcor.envfile, I added a warning message letting them know that they were choosing a differentNODE_ENVthan the defaultproductionvalue. I think this will help avoid opaque compilation bugs.