Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should yarn-error.log be added to .gitignore file? #1193

Closed
wiredin opened this issue Jan 20, 2018 · 4 comments
Closed

Should yarn-error.log be added to .gitignore file? #1193

wiredin opened this issue Jan 20, 2018 · 4 comments

Comments

@wiredin
Copy link

wiredin commented Jan 20, 2018

Should yarn-error.log be added to rails .gitignore automatically during webpacker setup?

@inkhrt
Copy link

inkhrt commented Jan 20, 2018 via email

@guilleiguaran
Copy link
Member

yarn-error.log is added automatically in new Rails apps except if yarn is skipped, doing it in webpacker will add repeated entries to the .gitignore file.

See: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/gitignore.tt#L31

/cc @gauravtiwari

@gauravtiwari
Copy link
Member

@guilleiguaran Ahh thanks :). Fixed: #1197

@wiredin
Copy link
Author

wiredin commented Jan 21, 2018

Thanks everyone! That makes sense, my app was originally rails version 5.0 so it did not already have yarn-error.log in the gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants