Enhancement for session binding #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
| @@ -64,6 +64,10 @@ def switch_binding_to(index) | |||
|
|
|||
| private | |||
|
|
|||
| def initial_binding | |||
| @bindings.find {|b| b.eval('__FILE__').start_with?(Rails.root.to_s) } | |||
There was a problem hiding this comment.
Can we expect that __FILE__ will always be a string? I think we can hit cases where it is nil for bindings in {instance_,class_,}eval string blocks, so we probably have to do b.eval('__FILE__').to_s in here.
Also a small style nit: { |b| vs {|b|.
There was a problem hiding this comment.
Yeah, I agree with that :-) I will fix them.
sh19910711
force-pushed
the
patch/0027/sync-traces-bindings
branch
from
c7e31ce to
d60583a
Compare
We should pass a binding or bindings to the Session.new()
sh19910711
force-pushed
the
patch/0027/sync-traces-bindings
branch
from
d60583a to
37be341
Compare
|
🎊 |
|
Thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to find a initial binding for each session. We use the first binding that is in
Rails.rootas the initial binding.Issue
From #194:
Details
Rails.rootRails.rootto return suitable path on testingThank you.