-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly identify hyphenated and alias command names #878
Correctly identify hyphenated and alias command names #878
Conversation
It worked correctly 👍 |
With thor 1.3.1 we've two failing tests: ``` Failing Scenarios: cucumber features/execute.feature:36 # Scenario: Show fail-fast default value in help cucumber features/execute.feature:44 # Scenario: Override fail-fast default value using config file ``` as a workaround to get CI green again we'r pinning to 1.3.0. I think the bug is fixed in rails/thor#878 but not yet released.
hey people, any chance this can get reviewed and merged? This fixes CI errors in one of my projects, https://github.com/voxpupuli/modulesync. |
lib/thor.rb
Outdated
# | ||
# ==== Returns | ||
# Boolean:: +true+ if the command exists, +false+ otherwise. | ||
def command_exists?(command_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this method in the public API? Should we :nodoc:
it instead? I don't think we have a need to expose this to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing. I added :nodoc:
.
40ab451
to
3821657
Compare
@rafaelfranca thanks for the merge! Would it be possible to make a new release? |
Fixes #868
Problem:
After version 1.3.0, invoking commands with hyphenated and alias names does not function as expected.
Given a Thor class definition as follows:
Each command results in the following.
This PR addresses the issue by implementing a fix in the
find_class_and_command_by_namespace
method, ensuring that it correctly identifies both hyphenated command names and their aliases.