Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ERB keyword argument check #719

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

casperisfine
Copy link

Later on later versions ERB.version has no prefix:

$ ruby -v
ruby 3.1.0dev (2021-10-06T06:42:37Z master d53493715c) [x86_64-darwin20]
$ ruby -rerb -e 'p ERB.version'
"2.2.3"

So It's better to check what the method parameters are like.

@yahonda
Copy link
Member

yahonda commented Jan 17, 2022

It would be very helpful if newer version of sprockets is released because Ruby 3.2.0dev finally removes positional arguments via ruby/ruby@d12a08a
and Rails CI is failing https://buildkite.com/rails/rails/builds/84046#9e481c18-b4a7-43fc-865d-4835b863ce40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants