Fix broken expansion of asset link paths #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for finding and fixing this issue! |
schneems
added a commit
that referenced
this pull request
Jul 9, 2019
schneems
added a commit
that referenced
this pull request
Jul 9, 2019
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Nov 4, 2019
Update ruby-sprockets to 4.0.0. * pkgsr change: Add "USE_LANGUAGES= # none". ## 4.0.0 - Fixes for Ruby 2.7 keyword arguments warnings [#625](rails/sprockets#625) - Manifest files are sorted alphabetically [#626](rails/sprockets#626) ## 4.0.0.beta10 - Fix YACB (Yet Another Caching Bug) [Fix broken expansion of asset link paths](rails/sprockets#614) ## 4.0.0.beta9 - Minimum Ruby version for Sprockets 4 is now 2.5+ which matches minimum ruby verision of Rails [#604] - Fix threading bug introduced in Sprockets 4 [#603] - Warn when two potential manifest files exist. [#560] ## 4.0.0.beta8 - Security release for [CVE-2018-3760](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-3760) ## 4.0.0.beta7 - Fix a year long bug that caused `Sprockets::FileNotFound` errors when the asset was present [#547] - Raise an error when two assets such as foo.js and foo.js.erb would produce the same output artifact (foo.js) [#549 #530] - Process `*.jst.eco.erb` files with ERBProcessor ## 4.0.0.beta6 - Fix source map line offsets [#515] - Return a `400 Bad Request` when the path encoding is invalid. [#514] ## 4.0.0.beta5 - Reduce string allocations - Source map metadata uses compressed form specified by the [source map v3 spec](https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k). [#402] **[BREAKING]** - Generate [index maps](https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit#heading=h.535es3xeprgt) when decoding source maps isn't necessary. [#402] - Remove fingerprints from source map files. [#402] ## 4.0.0.beta4 - Changing the version now busts the digest of all assets [#404] - Exporter interface added [#386] - Using ENV vars in templates will recompile templates when the env vars change. [#365] - Source maps for imported sass files with sassc is now fixed [#391] - Load paths now in error messages [#322] - Cache key added to babel processor [#387] - `Environment#find_asset!` can now be used to raise an exception when asset could not be found [#379] ## 4.0.0.beta3 - Source Map fixes [#255] [#367] - Performance improvements ## 4.0.0.beta2 - Fix load_paths on Sass processors [#223] ## 4.0.0.beta1 - Initial release of Sprockets 4 Please upgrade to the latest Sprockets 3 version before upgrading to Sprockets 4. Check the 3.x branch for previous changes https://github.com/rails/sprockets/blob/3.x/CHANGELOG.md.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from 36741c6 where a line was missed in the conversion.
See 36741c6#diff-dfbaed3e7b867e34b5441da43fc665e1L81 for the omitted line from the previous code.
Fixes #613.