Skip to content

Commit

Permalink
Merge pull request #105 from maclover7/master
Browse files Browse the repository at this point in the history
Add Contributing file
  • Loading branch information
rafaelfranca committed Dec 8, 2015
2 parents 8794346 + a174a3d commit 21476ea
Show file tree
Hide file tree
Showing 3 changed files with 126 additions and 25 deletions.
118 changes: 118 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
Contributing to Sprockets
=====================

[![Build Status](https://secure.travis-ci.org/rails/sprockets.svg?branch=master)](http://travis-ci.org/rails/sprockets)

Sprockets is work of [hundreds of contributors](https://github.com/rails/sprockets/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/rails/sprockets/pulls), [propose features and discuss issues](https://github.com/rails/sprockets/issues).

#### Fork the Project

Fork the [project on Github](https://github.com/rails/sprockets) and check out your copy.

```
git clone https://github.com/contributor/sprockets.git
cd sprockets
git remote add upstream https://github.com/rails/sprockets.git
```

#### Create a Topic Branch

Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.

```
git checkout master
git pull upstream master
git checkout -b my-feature-branch
```

#### Bundle Install and Test

Ensure that you can build the project and run tests.

```
bundle install
bundle exec rake test
```

#### Write Tests

Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build. Add to [test](test).

We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.

#### Write Code

Implement your feature or bug fix.

Make sure that `bundle exec rake test` completes without errors.

#### Write Documentation

Document any external behavior in the [README](README.md).

#### Update Changelog

Add a line to [CHANGELOG](CHANGELOG.md) under *Next Release*. Make it look like every other line, including your name and link to your Github account.

#### Commit Changes

Make sure git knows your name and email address:

```
git config --global user.name "Your Name"
git config --global user.email "[email protected]"
```

Writing good commit logs is important. A commit log should describe what changed and why.

```
git add ...
git commit
```

#### Push

```
git push origin my-feature-branch
```

#### Make a Pull Request

Go to https://github.com/contributor/sprockets and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.

#### Rebase

If you've been working on a change for a while, rebase with upstream/master.

```
git fetch upstream
git rebase upstream/master
git push origin my-feature-branch -f
```

#### Update CHANGELOG Again

Update the [CHANGELOG](CHANGELOG.md) with a short description of your change. A typical entry looks as follows.

```
* Fix static asset mtime fallback.
```

Amend your previous commit and force push the changes.

```
git commit --amend
git push origin my-feature-branch -f
```

#### Check on Your Pull Request

Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.

#### Be Patient

It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!

#### Thank You

Please do know that we really appreciate and value your time and work. We love you, really.
File renamed without changes.
33 changes: 8 additions & 25 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Or include it in your project's `Gemfile` with Bundler:
gem 'sprockets', '~> 3.0'
```

<<<<<<< HEAD
## Using sprockets

For most people interested in using sprockets you will want to see [End User Asset Generation](guides/end_user_asset_generation.md) guide. This contains information about sprocket's directive syntax, and default processing behavior.
Expand Down Expand Up @@ -69,6 +70,8 @@ Then create a file `foo/index.js` that requires all the files in that folder in

Now in your `application.js` will correctly load the `foo.min.js` before `foo-ui.js`. If you used `require_tree` it would not work correctly.

=======
>>>>>>> maclover7/master
## Understanding the Sprockets Environment

You'll need an instance of the `Sprockets::Environment` class to
Expand Down Expand Up @@ -480,36 +483,16 @@ def self.call(input)
end
```

## Contributing to Sprockets

## Development
Sprockets is the work of hundreds of contributors. You're encouraged to submit pull requests, propose
features and discuss issues.

### Contributing

The Sprockets source code is [hosted on
GitHub](https://github.com/rails/sprockets). You can check out a
copy of the latest code using Git:

$ git clone https://github.com/rails/sprockets

If you've found a bug or have a question, please open an issue on the
[Sprockets issue
tracker](https://github.com/rails/sprockets/issues). Or, clone
the Sprockets repository, write a failing test case, fix the bug and
submit a pull request.
See [CONTRIBUTING](CONTRIBUTING.md).

### Version History

Please see the [CHANGELOG](https://github.com/rails/sprockets/tree/master/CHANGELOG.md)

## Build Status

[![Build Status](https://travis-ci.org/rails/sprockets.svg?branch=master)](https://travis-ci.org/rails/sprockets)

## License

Copyright &copy; 2014 Sam Stephenson <<[email protected]>>

Copyright &copy; 2014 Joshua Peek <<[email protected]>>

Sprockets is distributed under an MIT-style license. See LICENSE for
details.
Sprockets is released under the [MIT License](MIT-LICENSE).

0 comments on commit 21476ea

Please sign in to comment.