Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy conditions #510

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Remove legacy conditions #510

merged 3 commits into from
Aug 10, 2022

Commits on Aug 10, 2022

  1. Remove check for append_assets_path initializer 

    It was removed from Rails in rails/rails@5172d93, and sprockets-rails
only supports Rails 5.2+

The initializer is also changed to be a simpler class method call
instead of reopening Rails::Engine, similarly to how it was changed in
rails/propshaft@c7d5542
    @skipkayhil
    skipkayhil committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    15dfcb6 View commit details
    Browse the repository at this point in the history

  2. Remove prepend conditional from RouteWrapper patch 

    Module#prepend was added in ruby 2.0, and the required ruby version is
2.5+

The Rails > 4 conditional will also always be true since the required
Rails version is 5.2+
    @skipkayhil
    skipkayhil committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    11a0387 View commit details
    Browse the repository at this point in the history

  3. Remove conditional for caller_locations 

    Kernel#caller_locations was added in ruby 2, and the required ruby
version is 2.5

The Rails version check will also always be true since the minimum Rails
version is 5.2
    @skipkayhil
    skipkayhil committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    05e40aa View commit details
    Browse the repository at this point in the history