Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific with required file #383

Merged
merged 1 commit into from
Nov 9, 2016
Merged

Conversation

EiNSTeiN-
Copy link
Contributor

This fixes a problem with being unable to load ActionView::Helpers::AssetUrlHelper from L7 in some situations

@rafaelfranca

This fixes a problem with being unable to load `ActionView::Helpers::AssetUrlHelper` from L7 in some situations
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arthurnn
Copy link
Member

arthurnn commented Nov 9, 2016

not sure why CI is failing, any clue?

@EiNSTeiN-
Copy link
Contributor Author

It looks unrelated, unfortunately I can't re-run the ci build (or if I can, I can't find the button to do it)

@rafaelfranca
Copy link
Member

I was debugging why this happening. When we require the action_view top file it setup an autoload hook for ActionView::Helpers pointing to action_view/helpers. In @EiNSTeiN- situation seems like a gem is define ActionView::Helpers before sprockets-rails is loaded so action_view/helpers will never be loaded since we only load it when the constant is missing.

Not loading action_view/helpers will not setup the autoload hooks for the helpers inside that file so we will see the LoadError exception.

@rafaelfranca rafaelfranca merged commit 6fa795a into rails:master Nov 9, 2016
@EiNSTeiN- EiNSTeiN- deleted the patch-1 branch November 9, 2016 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants