Import append_assets_path initializer #215
Conversation
| @@ -36,6 +36,17 @@ def assets | |||
| # Returns Sprockets::Manifest for app config. | |||
| attr_accessor :assets_manifest | |||
| end | |||
|
|
|||
| class Engine < Railtie | |||
There was a problem hiding this comment.
Is extending initializers on Engine allowed?
There was a problem hiding this comment.
Yes, it is, although it is not the best way of doing it.
Since we want to detect if the initializer was already defined I think we can't do better.
When we drop support to Rails 4 we can change it to instead of reopening Rails::Engine just define a Sprockets::Rails::Engine instead of a Railtie.
There was a problem hiding this comment.
When we drop support to Rails 4 we can change it to instead of reopening Rails::Engine just define a Sprockets::Rails::Engine instead of a Railtie.
Ah, cool, I didn't realize that would work.
| # Skip defining append_assets_path on Rails <= 4.2 | ||
| unless initializers.find { |init| init.name == :append_assets_path } | ||
| initializer :append_assets_path, :group => :all do |app| | ||
| if paths["app/assets"].respond_to?(:existent_directories) |
There was a problem hiding this comment.
Why bother with versions < 4 if the initializer is defined and we will not enter this code? It is just because Rails 3.0?
There was a problem hiding this comment.
:/ yeah, I just wanted to make the tests pass. This is merging into the old 2.x. I'll drop this condition when pulling this patch into master.
Import append_assets_path initializer
Alright, @rafaelfranca
Heres the idea for moving the
append_assets_pathinto this plugin.Then in rails/master we could completely remove
config.assetsand this guy. This code would still cover people running Rails 4.2. And eventually we can remove the guard when we only need to support Rails 5.Related discussion