Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all application.(js,css) files pulled in #218

Closed
scashin133 opened this issue Jan 27, 2015 · 3 comments · May be fixed by #437
Closed

all application.(js,css) files pulled in #218

scashin133 opened this issue Jan 27, 2015 · 3 comments · May be fixed by #437

Comments

@scashin133
Copy link

scashin133 commented Jan 27, 2015

I have a bower depedency on jquery-sortable, which includes application.(css.sass,js) files.

The default precompile logic

config.assets.precompile = [LOOSE_APP_ASSETS, /(?:\/|\\|\A)application\.(css|js)$/]
causes all application css and js files to be precompiled which was not the desired effect for this library.

2.2.0 :001 > 'vendor/assets/bower_components/jquery-sortable/source/js/application.js' =~ /(?:\/|\\|\A)application\.(css|js)$/
 => 56

Was this intentional?

There was an issue filed with jquery-sortable johnny/jquery-sortable#134 asking them to remove it but I didn't understand why it was precompiling it in the first place.

@josh
Copy link
Contributor

josh commented Jan 27, 2015

I definitely agree with you and I attempted to "fix" it recently, but apparently people are depending on this sort of thing. It ended up reverting the patch in the 2.x release. But I'm planning to have it locked down in the next major release 3.x which can have backwards incompatible changes. Thanks!

@josh josh closed this as completed Jan 27, 2015
@scashin133
Copy link
Author

Sounds good just wanted to make sure.

On Monday, January 26, 2015, Joshua Peek [email protected] wrote:

I definitely agree with you and I attempted to "fix" it recently, but
apparently people are depending on this sort of thing. But I'm planning to
have it locked down in the next major release 3.x which can have backwards
incompatible changes. Thanks!


Reply to this email directly or view it on GitHub
#218 (comment)
.

http://about.me/seancashin/bio

@bborn
Copy link

bborn commented Apr 9, 2015

+1 also think I'm running into this. bower install jquery-sortable brings in all the development files (sass, etc.) which then don't precompile correctly. Wouldn't it be better to only include the compiled js and css files?

eins78 added a commit to eins78/sprockets-rails that referenced this issue May 29, 2019
In previous versions it was possible to set (instead of extend) the `precompile` array.
This was broken, seemingly by accident, in rails@af64798

fixes rails#218
fixes rails#327
fixes rails#390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants