Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance test for under rails 5.1 #630

Closed

Conversation

Sixeight
Copy link
Contributor

@Sixeight Sixeight commented Oct 16, 2020

before after
image image

Why

What

  • Ensure 1 line of gem 'sqlite3' . ( commit )
  • Use gsub to comment out gem sqlite3' .

Other fails

Related

Fixes #614

@Sixeight Sixeight force-pushed the fix-test-for-under-rails-5.1.0 branch from 48f54a1 to 1fa2157 Compare October 24, 2020 03:56
…nder Rails 5.1

ex)
gem 'sqlite3'           #=> gem 'sqlite3', '1.4'
gem 'sqlite3', '~> 1.5' #=> gem 'sqlite3', '1.4'
@Sixeight Sixeight force-pushed the fix-test-for-under-rails-5.1.0 branch from 1fa2157 to 887d8e2 Compare October 24, 2020 04:48
@Sixeight Sixeight changed the title Fix acceptance test for under rails 5.1.0 Fix acceptance test for under rails 5.1 Oct 24, 2020
@Sixeight
Copy link
Contributor Author

Sixeight commented Feb 9, 2021

merged 🎉
#617

@Sixeight Sixeight closed this Feb 9, 2021
@Sixeight Sixeight deleted the fix-test-for-under-rails-5.1.0 branch February 9, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance test (and Spring.watch) both fail on my macos Catalina
1 participant