Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with Spring 4.1.2 #36

Closed
tdeo opened this issue Nov 20, 2023 · 2 comments · Fixed by rails/spring#706
Closed

Incompatible with Spring 4.1.2 #36

tdeo opened this issue Nov 20, 2023 · 2 comments · Fixed by rails/spring#706

Comments

@tdeo
Copy link

tdeo commented Nov 20, 2023 •
edited
Loading

The newest release of Spring (4.1.2) and particularly this commit makes this watcher broken:

NoMethodError: undefined method `synchronize' for #<Spring::Watcher::Listen:0x00000001062a2e50 ...
...

/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/spring-watcher-listen-2.1.0/lib/spring/watcher/listen.rb:61:in `changed'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/config.rb:28:in `call'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:117:in `block in _process_changes'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/thread.rb:26:in `rescue_and_log'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:116:in `_process_changes'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:25:in `block in loop_for'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:20:in `loop'
...

I believe this call to synchronize should be changed to @mutex.synchronize to mimic what happened in that commit
@fschwahn fschwahn mentioned this issue Nov 22, 2023
Merged
byroot added a commit to rails/spring that referenced this issue Nov 22, 2023
@byroot
Bring back Spring::Watcher::Abstract#synchronize
c1facc5 
Fix: rails/spring-watcher-listen#36
@byroot byroot mentioned this issue Nov 22, 2023
Merged
@byroot
Copy link
Member

byroot commented Nov 22, 2023

I just released Spring 4.1.3 which should fix this issue.

@tdeo
Copy link
Author

tdeo commented Nov 23, 2023

Thank you very much for the reactivity 🙏

JulianSage added a commit to JulianSage/spring that referenced this issue Oct 23, 2024
@JulianSage
Bring back Spring::Watcher::Abstract#synchronize
1e555d4 
Fix: rails/spring-watcher-listen#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring back Spring::Watcher::Abstract#synchronize rails/spring
2 participants
@byroot @tdeo