Added broadcast_list to SolidCable adapter #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ill wait to review/merge until that upstream PR lands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a PR on Rails repo to introduce new methods to ActionCable API in order to broadcast a message to a list of streams : rails/rails#52952
I thought it would be interesting to add related modifications to SolidCable so it's compliant with ActionCable, as soon as those updates are merged. (If they are!)
find_matching_channelsmethod is implemented as an helper (see https://github.com/rails/rails/pull/52952/files#diff-9127e7ecdaf8a93459e897fd30de231255465e4488b7b5088dd92ecb070f8172) so it should be removed at some point.