Rework method spotlight effect #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a67ece6 changed the HTML around method permalinks, which broke the spotlight effect when navigating to a specific method. However, prior to that commit (since upgrading to Turbo v7), the spotlight effect only worked for cross-page navigation, not intra-page navigation. This commit fixes the spotlight effect for both cross-page and intra-page navigation. Additionally, this commit changes the visual effect from a momentary flash of yellow to a persistent mark in the left margin. This ensures that effect is not missed (for example, when opening the page as a background tab), and is less jarring when using dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a67ece6 changed the HTML around method permalinks, which broke the spotlight effect when navigating to a specific method. However, prior to that commit (since upgrading to Turbo v7), the spotlight effect only worked for cross-page navigation, not intra-page navigation. This commit fixes the spotlight effect for both cross-page and intra-page navigation.
Additionally, this commit changes the visual effect from a momentary flash of yellow to a persistent mark in the left margin. This ensures that effect is not missed (for example, when opening the page as a background tab), and is less jarring when using dark mode.